-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover all remaining statements and expressions in the spec #514
Cover all remaining statements and expressions in the spec #514
Conversation
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 86 86
Lines 5550 5550
=======================================
Hits 4857 4857
Misses 693 693 Continue to review full report at Codecov.
|
7ec8375
to
ea61b14
Compare
6cfed48
to
eb09d5d
Compare
eb09d5d
to
e1d6b5e
Compare
735cf79
to
b4adff3
Compare
Btw, I'm going to add a CI check to ensure our code examples won't go out of date soon but that will be a different PR. |
Ok, I ended up adding the CI check to this PR (but happy to move it out on request) and it already found a few code examples that were out of date. |
3ed8d0a
to
15bfa88
Compare
15bfa88
to
587f335
Compare
587f335
to
9d0a748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I love that we check the snippets now.
|
||
return sum | ||
|
||
fn some_skip_condition -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. looks like the parser is letting func defs without parens through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, looks like the parser only disallows missing parens if the function name is immediately followed by a :
and hence declares no return type. I filed an issue: #523
What was wrong?
The spec didn't cover all statements and expressions of the language.
How was it fixed?
Added basic coverage of all statements and expressions plus a few extra goodies