Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore non-fatal parser errors when analysis succeeds #535

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

sbillig
Copy link
Collaborator

@sbillig sbillig commented Sep 5, 2021

What was wrong?

closes #523

Non-fatal parser errors were being ignored when the analysis stage succeeded. I assume this was my fault again (#402 😞). We probably need tests for the driver crate.

How was it fixed?

In the simplest way possible. I've done nothing to ensure that something similar won't happen again in the future.

To-Do

@codecov-commenter
Copy link

Codecov Report

Merging #535 (8397eee) into master (e256045) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   87.68%   87.67%   -0.02%     
==========================================
  Files          87       87              
  Lines        5670     5672       +2     
==========================================
+ Hits         4972     4973       +1     
- Misses        698      699       +1     
Impacted Files Coverage Δ
crates/driver/src/lib.rs 75.00% <50.00%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e256045...8397eee. Read the comment docs.

@cburgdorf cburgdorf merged commit 466d4b5 into ethereum:master Sep 6, 2021
@g-r-a-n-t g-r-a-n-t mentioned this pull request Sep 6, 2021
3 tasks
@sbillig sbillig deleted the fail-on-parser-errors branch September 12, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser doesn't reject functions with missing parenthesis
3 participants