Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use statements #547

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Use statements #547

merged 5 commits into from
Oct 6, 2021

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Sep 20, 2021 •
edited
Loading

What was wrong?

We originally had Python style import statements.

How was it fixed?

Replaced import statements with use statements.

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t marked this pull request as draft September 20, 2021 20:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #547 (7b05ac4) into master (e23abe3) will increase coverage by 0.02%.
The diff coverage is 77.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   87.50%   87.53%   +0.02%     
==========================================
  Files          88       88              
  Lines        5931     5993      +62     
==========================================
+ Hits         5190     5246      +56     
- Misses        741      747       +6
Impacted Files Coverage Δ
crates/analyzer/src/namespace/items.rs 89.78% <0.00%> (ø)
crates/lowering/src/mappers/module.rs 84.44% <0.00%> (ø)
crates/parser/src/lexer/token.rs 21.27% <0.00%> (-0.23%) ⬇️
crates/parser/src/parser.rs 75.52% <70.00%> (-1.67%) ⬇️
crates/parser/src/grammar/module.rs 87.28% <80.64%> (+1.03%) ⬆️
crates/parser/src/ast.rs 79.02% <90.47%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23abe3...7b05ac4. Read the comment docs.

g-r-a-n-t
g-r-a-n-t commented Sep 30, 2021
View reviewed changes
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
crates/parser/src/grammar/module.rs Outdated Show resolved Hide resolved
@g-r-a-n-t g-r-a-n-t force-pushed the module-system branch 4 times, most recently from dd4d8e9 to fc474ce Compare October 1, 2021 21:32
@g-r-a-n-t g-r-a-n-t force-pushed the module-system branch 2 times, most recently from 37ac236 to e073336 Compare October 1, 2021 22:31
g-r-a-n-t
g-r-a-n-t commented Oct 1, 2021
View reviewed changes
crates/test-files/fixtures/printing/defs.fe
@@ -1,3 +1,11 @@
use foo::bar as baz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the double lines are a bit ugly here, but Im inclined to keep things simple and leave it alone

@g-r-a-n-t g-r-a-n-t changed the title Basic module system Use statements Oct 1, 2021
@g-r-a-n-t g-r-a-n-t marked this pull request as ready for review October 1, 2021 22:52
@g-r-a-n-t g-r-a-n-t requested a review from sbillig October 4, 2021 15:09
sbillig
sbillig approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@g-r-a-n-t g-r-a-n-t merged commit 1e0711b into ethereum:master Oct 6, 2021
@sbillig sbillig mentioned this pull request Oct 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-r-a-n-t @codecov-commenter @sbillig