Refactor analyzer name resolution (resolve_name/NamedThing) #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates all named things into a
NamedThing
hierarchy, and name resolution into a singleresolve_name
chain (block -> fn -> contract -> module), along with some related refactoring. This is mostly groundwork for the module system, and moves us in the direction of representing built-ins as declarative structures that are analyzed using general-purpose code that will work for things defined in fe (when the language is sufficiently powerful).Notably, checking of generic type parameters for the built-in generic types String and Map is now handled in a general-purpose
apply_generic_type_args
function which will work for generic types defined in fe, rather than special-case code.Note that I've postponed the module-level fn definition support functionality for now. I'll do that in a separate PR.
To-Do
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history