Revert with proper panic if array index out of bounds #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/array-out-of-bounds-check
branch
from
8c41d75
to
1545487
Compare
cburgdorf
commented
Dec 9, 2021
|
|
||
| /// Returns a pointer to the array item at the requested index. | ||
| /// Reverts with a panic if the index is out of bounds. | ||
| pub fn get_array_item() -> yul::Statement { |
There was a problem hiding this comment.
I realize that this might eventually be handled at Fe level (std lib) but it is small enough to add now and is preventing me from adding further differential contract fuzzing tests as this comes up quite frequently when fuzzing with arrays involved.
There was a problem hiding this comment.
Don't hesitate to add yul utility functions; it'll be a while before everything can be fe-ified.
sbillig
approved these changes
Dec 11, 2021
|
|
||
| /// Returns a pointer to the array item at the requested index. | ||
| /// Reverts with a panic if the index is out of bounds. | ||
| pub fn get_array_item() -> yul::Statement { |
There was a problem hiding this comment.
Don't hesitate to add yul utility functions; it'll be a while before everything can be fe-ified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We do not yet revert with a proper
Panic(0x32)when trying to access an array item that is not within the bounds of the array.How was it fixed?
get_array_itemfunction that handles the check and used it in theindexed_arrayoperation