Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set function access in Json ABI based on presence of ctx and self parameter #678

Closed
g-r-a-n-t opened this issue Feb 27, 2022 · 1 comment · Fixed by #783
Closed

Set function access in Json ABI based on presence of ctx and self parameter #678

g-r-a-n-t opened this issue Feb 27, 2022 · 1 comment · Fixed by #783
Labels
good first issue Good for newcomers

Comments

@g-r-a-n-t
Copy link
Member

What is wrong?

As noted in #638, FunctionSignatures now include a ctx_decl attribute. If both the ctx_decl and self_decl attributes are None, then we can mark it as a pure function in the Json ABI.

example:

contract Foo:
  # this should be marked as pure
  pub fn add(a: u256, b: u256):
    pass

How can it be fixed

⌨️
@g-r-a-n-t g-r-a-n-t added the good first issue Good for newcomers label Feb 27, 2022
@g-r-a-n-t g-r-a-n-t changed the title Set function access in Json ABI based on presence ctx and self parameter Set function access in Json ABI based on presence of ctx and self parameter Mar 1, 2022
@Y-Nak
Copy link
Member

Y-Nak commented Mar 11, 2022 •
edited
Loading

This will be resolved in #676
It'd be better to wait for #703 to be merged.

@Y-Nak Y-Nak mentioned this issue Mar 11, 2022
Merged
3 tasks
@vuvoth vuvoth mentioned this issue Sep 2, 2022
Merged
3 tasks
@Y-Nak Y-Nak closed this as completed in #783 Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set function access in Json ABI based on presence of ctx and self parameter vuvoth/fe
2 participants
@Y-Nak @g-r-a-n-t