Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing attribute calls with generic args. #719

Merged
merged 1 commit into from
May 26, 2022
Merged

Parsing attribute calls with generic args. #719

merged 1 commit into from
May 26, 2022

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented May 24, 2022 •
edited
Loading

What was wrong?

The following expressions would not parse:

fe/crates/parser/tests/cases/parse_ast.rs

Lines 71 to 72 in e661fb6

test_parse! { expr_call3, expressions::parse_expr, "bing.foo<Bar>(x:3)" }
test_parse! { expr_call4, expressions::parse_expr, "bang.bing.foo<Bar, Baz>(26, 42)" }

How was it fixed?

Handle call expressions on the rhs when parsing attributes.

This feels hacky, so feel free to suggest better approaches,

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t changed the title hacking Generic call args fix May 24, 2022
@g-r-a-n-t g-r-a-n-t changed the title Generic call args fix Parsing attribute calls with generic args. May 25, 2022
@g-r-a-n-t g-r-a-n-t merged commit 03d3b8d into ethereum:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburgdorf cburgdorf cburgdorf approved these changes

@Y-Nak Y-Nak Y-Nak approved these changes

@sbillig sbillig Awaiting requested review from sbillig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-r-a-n-t @cburgdorf @Y-Nak