Fix regression of stateMutability not being included in ABI #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/fix/state_mutability
branch
from
3bc6634
to
cf96a88
Compare
cburgdorf
force-pushed
the
christoph/fix/state_mutability
branch
from
cf96a88
to
3bdd9cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
- Coverage 81.67% 81.66% -0.01%
==========================================
Files 105 105
Lines 11827 11827
==========================================
- Hits 9660 9659 -1
- Misses 2167 2168 +1
Continue to review full report at Codecov.
|
Y-Nak
approved these changes
May 26, 2022
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The new ABI crate that landed with #676 did not have the
stateMutabilityfield included. It should default topayablefor now.How was it fixed?
This is what #705 did but for the new ABI crate