Change comments from using # to using //
#776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/slash-comments
branch
from
781ab63
to
11ae8bb
Compare
|
This actually needed to be rebased. It's now causing a CI failure on master. I'll send a follow up. |
I pushed a fix directly to master 🤭 9300ef4 |
|
Yeah, I missed that. Thanks for following up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
It seems like we have consensus that we don't want to continue to use
#for comments but rather use//instead. This PR changes that.How was it fixed?
fehighlighting that the docs already use