Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctx param in tests #880

Merged
merged 1 commit into from
May 3, 2023
Merged

ctx param in tests #880

merged 1 commit into from
May 3, 2023

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented May 1, 2023 •
edited
Loading

What was wrong?

ctx couldn't be used in tests functions without a bit of hacking.

How was it fixed?

modified checks around the ctx param and updated tests.

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t requested review from sbillig and Y-Nak May 1, 2023 22:47
@g-r-a-n-t g-r-a-n-t mentioned this pull request May 1, 2023
Merged
3 tasks
sbillig
sbillig approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbillig sbillig merged commit e97fbcb into ethereum:master May 3, 2023
saifalkatout pushed a commit to saifalkatout/fe that referenced this pull request Sep 28, 2023
@g-r-a-n-t @saifalkatout
ctx param in tests (ethereum#880)
3ba5e13
saifalkatout pushed a commit to saifalkatout/fe that referenced this pull request Sep 28, 2023
@g-r-a-n-t @saifalkatout
ctx param in tests (ethereum#880)
15a9bcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

@Y-Nak Y-Nak Awaiting requested review from Y-Nak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-r-a-n-t @sbillig