Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where compiler doesn't reject method call on storage struct #881

Merged

Conversation

cburgdorf
Copy link
Collaborator

@cburgdorf cburgdorf commented May 2, 2023

What was wrong?

A regression caused the compiler to not properly reject code that is trying to call a method on an in-storage struct.

How was it fixed?

  • Ensured the check happens on the non-derefenced type.
  • Added a test case which we were missing and caused this regression to slip through

(cherry picked from commit 2a1cd2aa974570ec86314700ec09feba26d0f6b6)
@cburgdorf cburgdorf force-pushed the christoph/fix/call_storage_method branch from 61083b9 to 40f7a0b Compare May 2, 2023 10:54
@cburgdorf cburgdorf marked this pull request as ready for review May 2, 2023 10:57
@cburgdorf cburgdorf mentioned this pull request May 2, 2023
3 tasks
@cburgdorf cburgdorf requested a review from g-r-a-n-t May 2, 2023 10:57
@g-r-a-n-t g-r-a-n-t merged commit 701f776 into ethereum:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants