-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MemoryBuffer, precompiles, raw_call #885
Conversation
crates/library/std/src/buf.fe
Outdated
} | ||
} | ||
|
||
// todo: fix compiler panic produced by this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
report
crates/library/std/src/buf.fe
Outdated
return buf | ||
} | ||
|
||
// todo: fix compiler panic produced by this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
report this if not a duplicate issue
|
||
// todo: require no return value | ||
#test | ||
// todo: yulgen panic on `identity` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
report
df25226
to
a82226a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. Just make sure to file the issues if you haven't already.
@@ -0,0 +1,15 @@ | |||
pub fn min(_ x: u256, _ y: u256) -> u256 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to suggest that we could define an Ord
trait and then have the min
/ max
functions be generic and work with any T
that is Ord
but free floating functions such as these can not use generics yet as we only allow struct methods to be generic for now....so, nothing to see here.
added the following to the std lib:
ctx.raw_call(...)
To-Do