Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test assertion string bugfix #926

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Sep 11, 2023

What was wrong?

Yul codegen was failing to include string literals used in test assertions. This resulted in a compiler error.

Example:

#test
fn foo() {
    assert false, "oops"
}

How was it fixed?

I had to reorder some statements dealing with the analyzer context in the Yul test lowering function.

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t changed the title Test assertion string. Test assertion string bugfix Sep 12, 2023
@g-r-a-n-t g-r-a-n-t merged commit 7afab40 into ethereum:master Sep 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants