Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swarm Travis errors #18513

Closed
holiman opened this issue Jan 24, 2019 · 5 comments
Closed

Swarm Travis errors #18513

holiman opened this issue Jan 24, 2019 · 5 comments
Assignees
@nonsense @janos

Comments

@holiman
Copy link
Contributor

holiman commented Jan 24, 2019

New (?) travis errors from swarm

ok  	github.com/ethereum/go-ethereum/swarm/network/simulations/discovery	11.353s	coverage: 0.0% of statements
ERROR[01-23|18:26:50.812|swarm/network/stream/peer.go:91] Message send error, dropping peer        peer=bdcac44b0c07db54 err="write tcp 127.0.0.1:58908->127.0.0.1:34148: use of closed network connection"
ERROR[01-23|18:26:50.812|swarm/network/stream/peer.go:91] Message send error, dropping peer        peer=bdcac44b0c07db54 err="shutting down"
ERROR[01-23|18:26:50.812|swarm/network/stream/peer.go:91] Message send error, dropping peer        peer=bdcac44b0c07db54 err="shutting down"
ERROR[01-23|18:26:51.937|swarm/network/stream/peer.go:91] Message send error, dropping peer        peer=3e53362d6b7b0269 err="shutting down"
ERROR[01-23|18:27:11.961|p2p/protocols/protocol.go:235]   peer.handleIncoming                      err="Message handler error: (msg code 4): write pipe: deadline exceeded"
coverage: 76.0% of statements
panic: test timed out after 5m0s

... full panic trace ...

and also

--- FAIL: TestHiveStatePersistance (0.12s)
    hive_test.go:112: invalid number of entries: got 6, want 5
WARN [01-23|18:27:53.755] peerpot NNSet < NeighbourhoodSize

The latter is pretty easy to create locally, by adding a time.Sleep(time.Second) here: https://github.com/ethereum/go-ethereum/blob/master/swarm/network/hive_test.go#L105

I'll assign to Anton, please reassign as you see fit
@holiman holiman changed the title Travis errors Swarm Travis errors Jan 24, 2019
@nonsense nonsense mentioned this issue Jan 24, 2019
Closed
@nonsense
Copy link
Member

@holiman we will look into these asap.

@holiman
Copy link
Contributor Author

holiman commented Jan 29, 2019

New one:

ERROR[01-28|14:57:26.133|swarm/network/stream/delivery.go:266] Delivery.RequestFromPeers: peer doesn't have stream cap. we should have returned at sp == nil 
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="write tcp 127.0.0.1:36496->127.0.0.1:39324: use of closed network connection"
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.918|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.919|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:35.919|swarm/network/stream/peer.go:91]      Message send error, dropping peer        peer=d4e6d9214d0c75d4 err="shutting down"
ERROR[01-28|14:57:36.170|swarm/network/stream/delivery.go:266] Delivery.RequestFromPeers: peer doesn't have stream cap. we should have returned at sp == nil 
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x90327d]
goroutine 169 [running]:
github.com/ethereum/go-ethereum/swarm/network.(*Fetcher).doRequest(0xc0000b7900, 0xcca740, 0xc0017e19e0, 0xc0013a4600, 0xc0017e23f0, 0x0, 0x0, 0x0, 0x1, 0x0, ...)
	/home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/network/fetcher.go:307 +0x25d
github.com/ethereum/go-ethereum/swarm/network.(*Fetcher).run(0xc0000b7900, 0xcca740, 0xc0017e19e0, 0xc0017e23f0)
	/home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/network/fetcher.go:231 +0x4b8
created by github.com/ethereum/go-ethereum/swarm/network.(*FetcherFactory).New
	/home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/network/fetcher.go:114 +0x12f
FAIL	github.com/ethereum/go-ethereum/swarm/network/stream	10.105s

@nonsense
Copy link
Member

@holiman yes, we are aware of this one. @janos is working on it.

@janos janos self-assigned this Jan 29, 2019
@nolash nolash mentioned this issue Jan 29, 2019
Merged
@janos
Copy link
Contributor

janos commented Jan 31, 2019

The problem with nil pointer dereference in delivery should be fixed in #18971 and pss timeout in #18964. Can we close this issue?

@nonsense
Copy link
Member

Closing. Let's re-open in case there are more flaky tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nonsense nonsense

@janos janos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nonsense @janos @holiman