Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use golangci-lint to replace gometalinter #19673

Closed
studyzy opened this issue Jun 6, 2019 · 1 comment · Fixed by #20295
Closed

use golangci-lint to replace gometalinter #19673

studyzy opened this issue Jun 6, 2019 · 1 comment · Fixed by #20295
Assignees
@fjl
Milestone
1.9.8

Comments

@studyzy
Copy link

studyzy commented Jun 6, 2019

Hi there,

gometalinter has been deprecated, please use https://github.com/golangci/golangci-lint to replace in build/ci.go lint command.

GolangCI-Lint said: it is a linters aggregator. It's fast: on average 5 times faster than gometalinter.
@karalabe karalabe added this to the 1.9.1 milestone Jun 6, 2019
@fjl fjl self-assigned this Jun 6, 2019
@fjl
Copy link
Contributor

fjl commented Jun 6, 2019

Assigning myself because I'm interested in integrating the depguard linter.

@karalabe karalabe modified the milestones: 1.9.1, 1.9.2 Jul 23, 2019
@karalabe karalabe modified the milestones: 1.9.2, 1.9.3 Aug 13, 2019
@karalabe karalabe modified the milestones: 1.9.3, 1.9.4 Sep 4, 2019
@karalabe karalabe modified the milestones: 1.9.4, 1.9.5 Sep 19, 2019
@fjl fjl modified the milestones: 1.9.5, 1.9.6 Sep 20, 2019
@fjl fjl modified the milestones: 1.9.6, 1.9.7 Oct 3, 2019
@karalabe karalabe modified the milestones: 1.9.7, 1.9.8 Nov 8, 2019
@fjl fjl mentioned this issue Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjl fjl

Labels
None yet
Projects
None yet
Milestone
1.9.8
Development

Successfully merging a pull request may close this issue.

build: use golangci-lint fjl/go-ethereum
3 participants
@fjl @karalabe @studyzy