Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote Snapshot extension registration failed to DEBUG instead of WARN #25200

Closed
Neurone opened this issue Jun 29, 2022 · 4 comments
Closed

Demote Snapshot extension registration failed to DEBUG instead of WARN #25200

Neurone opened this issue Jun 29, 2022 · 4 comments

Comments

@Neurone
Copy link
Contributor

Neurone commented Jun 29, 2022

I want to bring this conversation up again.

#24475 Changed the message from ERROR to WARN. I think this should be demoted to DEBUG.
I see many of these warnings in the log, and I ignore them - someone doesn't? - so they are not warnings anymore, just noise.

Because it's something related to other nodes, I cannot do anything about that. Is it correct?
Otherwise, how I should fix, or help to fix, those warnings?

@Neurone
Copy link
Contributor Author

Neurone commented Jun 29, 2022

@ligi @nicjansma what do you think about this?

@karalabe
Copy link
Member

This is caused - I think - by Optimism nodes who renamed the eth protocol in their network but not the snap. It's an issue that we're hitting these peers and we should fix it so the discovery does not give them back to us. Until then, it's unfortunately an issue in peering, even if harmless.

@Neurone
Copy link
Contributor Author

Neurone commented Jun 29, 2022

This is caused - I think - by Optimism nodes who renamed the eth protocol in their network but not the snap. It's an issue that we're hitting these peers and we should fix it so the discovery does not give them back to us. Until then, it's unfortunately an issue in peering, even if harmless.

Ok, I see. But if that's just a reminder for developers to address an issue, then it's a bit too intrusive for the geth's common users to have it as a warning, even more, because it's actually harmless and they cannot do anything about that.

@kayagoban
Copy link

If it's harmless, why is it a Warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants