Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back benchmarking tests #2046

Open
kclowes opened this issue Dec 9, 2021 · 0 comments
Open

Add back benchmarking tests #2046

kclowes opened this issue Dec 9, 2021 · 0 comments

Comments

@kclowes
Copy link
Collaborator

kclowes commented Dec 9, 2021

What is wrong?

The benchmarking tests are failing because of a dependency resolution error with web3.py's typing-extensions dep. It's going to take a bit to get the dependencies resolved, and I want to get Arrow Glacier support in sooner than later. Performance is less important now than it was when trinity was using py-evm to be a mainnet client. I took out the benchmarking CI run in PR #2040. This test run has the dependency resolution chain: https://app.circleci.com/pipelines/github/ethereum/py-evm/2053/workflows/465fee73-0b8f-47b6-9ae9-7e45803c4dad/jobs/155952.

How can it be fixed

Loosen typing-extension dependency restrictions in web3.py and then release. See: ethereum/web3.py#2217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant