Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bin/soljson-latest.js in solc-bin with a symlink #13508

Closed
cameel opened this issue Sep 8, 2022 · 1 comment · Fixed by ethereum/solc-bin#156
Closed

Replace bin/soljson-latest.js in solc-bin with a symlink #13508

cameel opened this issue Sep 8, 2022 · 1 comment · Fixed by ethereum/solc-bin#156
Assignees
@clonker
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0. refactor solcbin
Milestone
0.8.28

Comments

@cameel
Copy link
Member

cameel commented Sep 8, 2022

We tried to make it a symlink in ethereum/solc-bin#33 but back then we still served binaries via Github Pages and that does not support symlinks so we reverted the change in ethereum/solc-bin#44. Now that we switched to AWS for hosting, we can revisit the idea.
@cameel cameel added solcbin low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. refactor labels Sep 8, 2022
@cameel cameel added the should have We like the idea but it’s not important enough to be a part of the roadmap. label Sep 20, 2022
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 31, 2023
@github-actions github-actions bot added the closed due inactivity The issue/PR was automatically closed due to inactivity. label Apr 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2023
@cameel cameel reopened this Sep 11, 2024
@cameel cameel removed closed due inactivity The issue/PR was automatically closed due to inactivity. stale The issue/PR was marked as stale because it has been open for too long. labels Sep 11, 2024
@ethereum ethereum deleted a comment from github-actions bot Sep 11, 2024
@ethereum ethereum deleted a comment from github-actions bot Sep 11, 2024
@cameel
Copy link
Member Author

cameel commented Sep 11, 2024 •
edited
Loading

Reopening, since this started actually causing issues now. Apparently the mechanism for updating soljson-latest.js broke and it hasn't been updated since 0.8.19 (#14676 (comment)). We updated the it manually to 0.8.27 now (ethereum/solc-bin#155) but we can easily forget again so this needs a fix ASAP.

@cameel cameel added this to the 0.8.28 milestone Sep 11, 2024
@cameel cameel added must have Something we consider an essential part of Solidity 1.0. and removed nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. should have We like the idea but it’s not important enough to be a part of the roadmap. labels Sep 11, 2024
@clonker clonker mentioned this issue Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clonker clonker

Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0. refactor solcbin
Projects
None yet
Milestone
0.8.28
Development

Successfully merging a pull request may close this issue.

Use symlink for bin/soljson-latest.js ethereum/solc-bin
2 participants
@cameel @clonker