Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification of withdrawal credentials #40

Open
CarlBeek opened this issue Jun 11, 2020 · 2 comments
Open

Verification of withdrawal credentials #40

CarlBeek opened this issue Jun 11, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@CarlBeek
Copy link
Collaborator

It is very scary to me that withdrawal credentials are not verified at any point after generation. Adding a withdrawal signature & and the full withdrawal public key would allow verification of the key and it's encoding which would be a comforting sanity check.
@CarlBeek CarlBeek added the enhancement New feature or request label Jun 11, 2020
@hwwhww hwwhww mentioned this issue Nov 5, 2020
Closed
@hwwhww
Copy link
Contributor

hwwhww commented Mar 25, 2021

#195 would fix this.

@hwwhww
Copy link
Contributor

hwwhww commented Mar 30, 2021

Update: #195 verifies the withdrawal public key validation but not the withdrawal signature. We mostly rely on the launchpad to double verify the signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hwwhww @CarlBeek