Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up tx signing errors #2063

Closed
wants to merge 2 commits into from
Closed

Conversation

gabmontes
Copy link
Contributor

This is a proposal to solve the Unhandled Promise Rejection reported in #2062.

If for any reason the call to signTransaction fails, the promiEvent created during the contract method call will emit an error message -if working as an event emitter- and will also be rejected.

@coveralls
Copy link

coveralls commented Nov 23, 2018

Coverage Status

Coverage decreased (-0.2%) to 82.927% when pulling ca76f76 on bloq:capture-send-err into 0d54d94 on ethereum:1.0.

@nivida
Copy link
Contributor

nivida commented Nov 23, 2018

Hay @gabmontes could you do your changes again the ethereumProvider branch? But I think this issue should already be solved there :)

@nivida nivida added the Enhancement Includes improvements or optimizations label Dec 1, 2018
@nivida
Copy link
Contributor

nivida commented Jan 21, 2019

This issue got solved in the PR #2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants