Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setContenthash docs formatting #3511

Merged
merged 1 commit into from
May 18, 2020
Merged

Fix setContenthash docs formatting #3511

merged 1 commit into from
May 18, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented May 8, 2020 •
edited
Loading

Description

⚠️ PR targets release/1.2.8 branch ⚠️

Fixes problems in the setContenthash section exposed by the 1.2.8-rc.0 docs build:

  • mis-formatted link
  • typo / over-long lines

@cgewecke cgewecke added 1.x 1.0 related issues Documentation Relates to project wiki or documentation labels May 8, 2020
holgerd77
holgerd77 approved these changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgewecke cgewecke merged commit 16c44d4 into release/1.2.8 May 18, 2020
@cgewecke cgewecke deleted the fix/contenthash-docs branch May 18, 2020 17:11
@ryanio ryanio mentioned this pull request May 18, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Release Patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgewecke @holgerd77