Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wait_for_transaction_receipt timeout type sig from float to Optional[float] #2685

Closed
Tracked by #2854
ariel-simnegar opened this issue Oct 19, 2022 · 0 comments · Fixed by #3237
Closed
Tracked by #2854

Comments

@ariel-simnegar
Copy link

Right now w3.eth.wait_for_transaction_receipt works just fine with timeout=None, because timeout is passed to asyncio.wait_for which accepts an Optional[float] timeout.

I think explicitly supporting timeout=None is useful for when wait_for_transaction_receipt is a subroutine in higher-level code which wants to specify an optional timeout and trivially delegate that to wait_for_transaction_receipt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant