Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename beacon/main.py -> beacon/beacon.py #3108

Closed
Tracked by #2854
fselmo opened this issue Sep 22, 2023 · 0 comments
Closed
Tracked by #2854

Rename beacon/main.py -> beacon/beacon.py #3108

fselmo opened this issue Sep 22, 2023 · 0 comments
Labels
v7 breaking changes considered for v7

Comments

@fselmo
Copy link
Collaborator

fselmo commented Sep 22, 2023

What was wrong?

Sticking to convention, we should rename web3/beacon/main.py -> web3/beacon/beacon.py. Though this is a minor change, it's breaking, so let's consider this for v7.

Similar examples:

  • web3/eth/eth.py
  • web3/contract/contract.py
  • ens/ens.py
@fselmo fselmo added the v7 breaking changes considered for v7 label Sep 22, 2023
@fselmo fselmo mentioned this issue Sep 22, 2023
Closed
@reedsa reedsa mentioned this issue Feb 20, 2024
Merged
1 task
@reedsa reedsa closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v7 breaking changes considered for v7
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reedsa @fselmo