Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state_override argument to estimate_gas #3164

Closed
Tracked by #2854
kclowes opened this issue Dec 11, 2023 · 2 comments · Fixed by #3168
Closed
Tracked by #2854

Add state_override argument to estimate_gas #3164

kclowes opened this issue Dec 11, 2023 · 2 comments · Fixed by #3168
Assignees
@reedsa

Comments

@kclowes
Copy link
Collaborator

kclowes commented Dec 11, 2023

What was wrong?

As of geth 1.12.1, estimate_gas allows a state_override argument.

How can it be fixed?

Allow eth.estimate_gas to take the state_override param. Can follow the existing eth.call implementation.
@reedsa reedsa self-assigned this Dec 14, 2023
@reedsa reedsa mentioned this issue Dec 14, 2023
Merged
1 task
@reedsa reedsa added the v7 breaking changes considered for v7 label Jan 10, 2024
@reedsa
Copy link
Contributor

reedsa commented Jan 10, 2024

Planning this as part of v7 (#2854) since this requires an upgrade of geth which appears to be a bit more involved.

@reedsa reedsa mentioned this issue Jan 10, 2024
Closed
@fselmo fselmo removed the v7 breaking changes considered for v7 label Jan 31, 2024
@fselmo
Copy link
Collaborator

fselmo commented Jan 31, 2024

no longer v7 only since #3209 was merged

@reedsa reedsa mentioned this issue Feb 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reedsa reedsa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Estimate Gas with State Override reedsa/web3.py
3 participants
@reedsa @fselmo @kclowes