You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I discovered while working on my blobs4every1 project that the implementation of .toJSON in the BlobEIP4844Transaction class doesn't put the versionedHashes field in the JSON object.
We should consider updating the toJSON implementation for BlobEIP4844Transaction to include all the 4844 fields (or some subset of them). We should also think about adding a networkWrapperToJSON function that creates a JSON object with the blobs, commitments, proof, and versioned hashes as well.
The text was updated successfully, but these errors were encountered:
So after conversation with @scorbajio and a review of the relevant piece of the transaction in the execution APIs, I think our current JSON object for blob transactions is probably valid, with the exception of maybe adding blobs as its own field (though that isn't in the 4844 transaction type but a field on the GenericTransaction spec at the bottom so not sure entirely what that means).
I still think it be fruitful to produce a networkWrapperToJson that extends the toJSON function on the 4844 transaction type and adds the blobs, commitments, and proof fields as hexadecimal strings. That would be a nice additional tool for people wanting to create transactions to broadcast to the network. Additionally, we could update blobs4every1 to use this as a demo of how it works.
I discovered while working on my
blobs4every1
project that the implementation of.toJSON
in theBlobEIP4844Transaction
class doesn't put theversionedHashes
field in the JSON object.We should consider updating the
toJSON
implementation forBlobEIP4844Transaction
to include all the 4844 fields (or some subset of them). We should also think about adding anetworkWrapperToJSON
function that creates a JSON object with the blobs, commitments, proof, and versioned hashes as well.The text was updated successfully, but these errors were encountered: