Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Types not detected for ethjs-util re-exported methods #219

Closed
s1na opened this issue Sep 3, 2019 · 2 comments · Fixed by #248
Closed

Types not detected for ethjs-util re-exported methods #219

s1na opened this issue Sep 3, 2019 · 2 comments · Fixed by #248

Comments

@s1na
Copy link
Contributor

s1na commented Sep 3, 2019

Here we're re-exporting methods of ethjs-util:

const ethjsUtil = require('ethjs-util')
import BN = require('bn.js')
import rlp = require('rlp')
Object.assign(exports, ethjsUtil)

But because they're manually added to the exports object, typescript is not adding type definitions for them and Typescript users get an error when using one of those methods, e.g. stripHexPrefix.

@a1300
Copy link

a1300 commented Oct 17, 2019

Please assign this issue to me

@s1na
Copy link
Contributor Author

s1na commented Oct 21, 2019

Hi @a1300. Thanks for offering to help. I've assigned the issue to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants