-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external statemanager in VM constructor #264
Conversation
6ff8e62
to
9191f40
Compare
Probably will already ease things. I have a bit the fear, that the API remains too implicit, if Just started to wrap my head around this though, so have not formed an opinion myself on this. |
The goal of this is to make it less error prone for those who already modify it to do so. State manager should be cleaned up and/or redesigned but that may take a while (forever?). Probably a good middle ground is having this patch, but marking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeps backwards compatibility while offering additional flexibility to ethereumjs-vm users. I approve!
@holgerd77 added a bold @jwasinger please reapprove if still happy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this EXPERIMENTAL placing in the API docs, will approve.
Fixes #33.