-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move initial iterateVm checks to after step hook #279
Conversation
To ensure those conditions still generate a valid step for `runStepHook` handler.
Thanks @axic! |
@cdetrio does tracing outputs the last opcode even if it fails? |
@axic trace steps are structured so that the program counter refers to the opcode about to happen. so in failing transactions, I would think you'd want to see the last opcode? cause that's the one that "broke"? (Although I'm not sure how much of what I just said is |
It should match what |
@cdetrio @jwasinger merging this now |
The readme also stated:
So this change should be close to what the readme is saying. |
Update Account.isEmpty to be EIP-161 compliant / New v7.0.7 Release
To ensure those conditions still generate a valid step for
runStepHook
handler.The initial checks otherwise prevent certain situations from generating steps (e.g. for trace output)