Added usage of sealEngine to blockchain tests #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
force-pushed
the
update-blockchain-test-format
branch
from
4b2a165 to
34e29a9
Compare
|
Since this is fixing the before-failing blockchain test runs and is not touching production code, I will merge. |
|
Have also re-activated the temporarily deactivated exemplary blockchain tests runs ( |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the usage of the new
sealEngineparameter from the new blockchain test format (see this PR ethereum/tests#533 over on the tests repo).This should both fix currently failing blockchain tests due to not comparing to PoW-related params (
mixHash, see this comment e.g.) any more and at the same time significantly speed up blockchain test runs (we might be able to directly include these in the normal CI runs now, will do another blockchain test run after merge for getting the execution time).