Reset selfdestruct on revert

[mattdean-digicatapult]

Fixes test TouchToEmptyAccountRevert3 on Constantinople.

Once #326 is merged this should mean all the tests now pass 🎉

[rmeissner]

@mattdean-digicatapult now another state test fails :/

[mattdean-digicatapult]

Noooooo, I thought I had it. Will check, thanks @rmeissner

[mattdean-digicatapult]

Hang on @rmeissner, how did you get a failure? I've just replayed this commit on top of the eip-1052 branch and I'm getting no failures

[rmeissner]

I looked at the results of the ci: https://circleci.com/gh/ethereumjs/ethereumjs-vm/3060?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

[mattdean-digicatapult]

So there's 14 failures for that build and 15 for master https://circleci.com/gh/ethereumjs/ethereumjs-vm/3012. The difference being the 14 fixed in #326 right?

[rmeissner]

Ahh I forgot that EXTCODEHASH was not merged :D .... so yeah we have ... all tests should be fixed if both PRs are merged :D

[mattdean-digicatapult]

Awesome, more than happy BTW to rebase this on top of the merged EXTCODEHASH changes and get the first fully passing build in a long time

[holgerd77]

Just merged EXTCODEHASH. 😄

[holgerd77]

Looks good.

[mattdean-digicatapult]

rebased, sorry @holgerd77

[coveralls]

Coverage increased (+0.01%) to 90.416% when pulling 70dd74a on reset-selfdestruct-on-revert into 839417d on master.

[rmeissner]

WOHOOOOO all tests pass gz @mattdean-digicatapult @holgerd77

[holgerd77]

Whew, that was a long way.

Congrats, everyone!!!

[holgerd77]

Looks good.