storageAt Error: hex data is odd-length

[wighawag]

When calling provider.getStorageAt to a storage slot with zero data I get :

Error: hex data is odd-length (argument="value", value="0x0", code=INVALID_ARGUMENT, version=bytes/5.0.5)

I guess this is because the raw data from the rpc is "0x0" and ethers does not try to sanitize that before passing to hexlify here :

ethers.js/packages/providers/src.ts/base-provider.ts

Line 973 in e0b1d0e

return hexlify(await this.perform("getStorageAt", params));

[ricmoo]

What backend is this? Can you send me an address and storage position and backend you used for this?

This used to be a bug in old versions of ganache. I’ll fix it, but curious about who’s doing this. :)

[wighawag]

This was running in a test against hardhat : https://github.com/nomiclabs/hardhat
I created an issue there : NomicFoundation/hardhat#978

[ricmoo]

It looks like this was fixed upstream. And I'm debating now whether it makes sense for ethers to try interpreting this sort of result. If treated as a bytes, it should pad on the right, if a value pad on the left. Since it is ambiguous, I think I'm going to recommend not handling invalid data in this case...

I'm open to discussion though.

[ricmoo]

Closing this now, but please feel free to re-open to continue discussions.

Thanks! :)