Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.15 and libp2p go-quic support #575

Closed
janos opened this issue Aug 14, 2020 · 2 comments · Fixed by #596
Closed

Go 1.15 and libp2p go-quic support #575

janos opened this issue Aug 14, 2020 · 2 comments · Fixed by #596

Comments

@janos
Copy link
Member

janos commented Aug 14, 2020

With the latest Go release 1.15, a numerous changes were made to crypto/tls package, which made github.com/marten-seemann/qtls incompatible resulting a panic in both tests and built binary.

panic: qtls.ClientSessionState not compatible with tls.ClientSessionState

goroutine 1 [running]:
github.com/lucas-clemente/quic-go/internal/handshake.init.2()
        /Users/janos/go/pkg/mod/github.com/lucas-clemente/quic-go@v0.17.1/internal/handshake/unsafe.go:26 +0x205

This issue is submitted upstream quic-go/quic-go#2614 and there is an ongoing effort to solve it.

Go 1.15 brings some nice improvements but we do not need to upgrade right away.

Currently, we can remove github.com/libp2p/go-libp2p-quic-transport import from libp2p.go and completely remove the QUIC support, which is disabled by default because of some other issues.

We can postpone Go 1.15 support until beta release and wait for the upstream fix instead removing support for QUIC protocol on P2P layer.

@janos
Copy link
Member Author

janos commented Aug 20, 2020

Upstream issue is resolved, but I would suggest to wait for quic-go release including this fix before upgrading the dependency.

@janos
Copy link
Member Author

janos commented Aug 20, 2020

Package go-libp2p-quic-transport needs a fix an a release libp2p/go-libp2p-quic-transport#171 in order to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant