Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Create a PR with the non-swarm changes of swarm-network-rewrite #419

Closed
gbalint opened this issue Apr 23, 2018 · 2 comments · Fixed by ethereum/go-ethereum#16898
Closed

Create a PR with the non-swarm changes of swarm-network-rewrite #419

gbalint opened this issue Apr 23, 2018 · 2 comments · Fixed by ethereum/go-ethereum#16898
Assignees
@acud
Milestone
0.3 breaking changes

Comments

@gbalint
Copy link

gbalint commented Apr 23, 2018 •
edited
Loading

#171 is a huge PR. Let's separate the non-swarm parts, submit them to ethereum/go-ethereum, and then after merging this we will be able to create a huge, but at least swarm-only PR to merge the rest

First you can try it on ethersphere/master to see if travis is green and everything is ok
@gbalint gbalint added this to the 0.3 breaking changes milestone Apr 23, 2018
@acud
Copy link
Member

acud commented May 23, 2018 •
edited
Loading

taking care of vendoring now

@acud acud self-assigned this Jun 5, 2018
@acud
Copy link
Member

acud commented Jun 5, 2018

vendoring PR on main eth repo is good to go.
the other changes are still pending review

This was referenced Jun 5, 2018
Closed
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acud acud

Labels
None yet
Projects
None yet
Milestone
0.3 breaking changes
2 participants
@gbalint @acud