-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding op-nethermind #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got an example of what kinda config file we are looking for? |
Flcl will write a tiny thing to convert the genesis.json into the format they need |
would be a prime time to just make nethermind read genesis.json format lol |
barnabasbusa
reviewed
Jul 2, 2024
barnabasbusa
approved these changes
Jul 3, 2024
barnabasbusa
reviewed
Jul 4, 2024
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
barnabasbusa
added a commit
that referenced
this pull request
Nov 22, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](1.0.0...1.1.0) (2024-11-21) ### Features * add additional configuration options for participants ([#81](#81)) ([05d0fe9](05d0fe9)) * add custom configurable forks ([#59](#59)) ([878906a](878906a)) * add hildr ([#42](#42)) ([e1ce08e](e1ce08e)) * add k8s tests ([#45](#45)) ([168f062](168f062)) * add op_contract_deployer_params/image ([#63](#63)) ([9416a86](9416a86)) * add op-besu ([#58](#58)) ([08e7548](08e7548)) * add op-erigon - mininny ([#38](#38)) ([c69bf34](c69bf34)) * add sanity check ([#50](#50)) ([ceaa9a9](ceaa9a9)) * Add support for op-deployer, fix multiple L2s ([#74](#74)) ([eb59380](eb59380)) * add version.txt ([#36](#36)) ([1d10311](1d10311)) * add wait for sync for non kurtosis chains ([#49](#49)) ([0452e11](0452e11)) * Adding op-nethermind ([#46](#46)) ([fba71dd](fba71dd)) * op-deployer upgrade, fix fork support ([#88](#88)) ([f8d9089](f8d9089)) * Output Admin Private Key ([#71](#71)) ([95abc10](95abc10)) ### Bug Fixes * ci jobs only notify if discord secret available ([#48](#48)) ([9473f89](9473f89)) * contract string ([#82](#82)) ([c062de0](c062de0)) * count for participant was not calculated with ([#89](#89)) ([f511988](f511988)) * DNS-1035 label ([#44](#44)) ([1bf8541](1bf8541)) * erigon perms issue ([#76](#76)) ([0328314](0328314)) * explicitly set client contexts0 ([30017f2](30017f2)) * force offset time to be int ([#64](#64)) ([74b6417](74b6417)) * github action should fail if any jobs fail ([#78](#78)) ([577ca3b](577ca3b)) * grammar in docs ([#33](#33)) ([d6fb36f](d6fb36f)) * handling of config options ([#85](#85)) ([5b085c8](5b085c8)) * image label name too long, truncate at 63 chars ([#90](#90)) ([5bd687c](5bd687c)) * l2 contract deployment ([#35](#35)) ([3f2b16d](3f2b16d)) * Provide default participants ([#77](#77)) ([a7d72da](a7d72da)) * Remove wait for finalization for create2 factory deployment ([#60](#60)) ([d4c37f0](d4c37f0)) * test k8s ([#47](#47)) ([ac17e89](ac17e89)) * trust l1 rpc in op-node ([#41](#41)) ([05dcd2e](05dcd2e)) * Update neth image; improve genesis tool ([#73](#73)) ([71e61c8](71e61c8)) * update op-geth hash based storage ([#61](#61)) ([f0b5b23](f0b5b23)) * Validate root params ([#79](#79)) ([914a808](914a808)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The op-nethermind image is found here:
nethermindeth/nethermind:op-9b835cf
, it isn't stable/out yet so this is probably best left as a WIP for now.The major missing piece: op-nethermind needs a config.json file, but op-node doesn't seem to output it. So we gotta find a way to template or generate that file for the network before this PR can have a chance to work.