Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenId4VCIConfig.usePAR false seems to be ignored #82

Closed
avdwerff-ddy opened this issue Oct 3, 2024 · 2 comments
Closed

OpenId4VCIConfig.usePAR false seems to be ignored #82

avdwerff-ddy opened this issue Oct 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@avdwerff-ddy
Copy link

It seems that when setting OpenId4VCIConfig.usePAR to false, the library still throws in AuthorizationServerClient with

if let pushedAuthorizationRequestEndpoint = data.pushedAuthorizationRequestEndpoint, let url = URL(string: pushedAuthorizationRequestEndpoint) { self.parEndpoint = url } else { throw ValidationError.error(reason: "In valid authorization endpoint") }

Shouldn't it be possible to completely skip this, so pushedAuthorizationRequestEndpoint can be nil in the Credential Offer?

Presuming PAR refers to:

  var authorizationServerSupportsPar: Bool {
    switch self {
    case .oidc(let metaData):
      return metaData.pushedAuthorizationRequestEndpoint != nil
    case .oauth(let metaData):
      return metaData.pushedAuthorizationRequestEndpoint != nil
    }
  }
@dtsiflit dtsiflit self-assigned this Oct 4, 2024
@dtsiflit dtsiflit mentioned this issue Oct 4, 2024
10 tasks
@dtsiflit
Copy link
Contributor

dtsiflit commented Oct 4, 2024

@avdwerff-ddy Thank you very much for submitting this!

There is now a PR that addresses this will be merged very soon.

@dtsiflit dtsiflit added the bug Something isn't working label Oct 4, 2024
@dtsiflit
Copy link
Contributor

eu-digital-identity-wallet/eudi-lib-ios-wallet-kit#83
This issue has been addressed here also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants