Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: update to use a library that support all encryptions #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goncalo-frade-iohk
Copy link

@goncalo-frade-iohk goncalo-frade-iohk commented Sep 14, 2024

Description of change

This PR will support the Jose library (Jose-swift)[https://github.com/beatt83/jose-swift] that was added on (sdjwt)[https://github.com/eu-digital-identity-wallet/eudi-lib-sdjwt-swift], this library already provides all the encoding requirements without the need to fork the library causing dependency conflicts.

The BindingKey.jwk now allows support for KeyRepresentable this adds support for different type of keys besides SecKey as the privateKey parameter.
This means you can pass any of the following key struct/enum/classes JWK, RSA, P256, P384, P512, Curve25519, secp256k1, SecKey.

Also adds support for c20p

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

It runs all the tests correctly with this library without any changes on the behaviour of the logic code. So no tests were added and all the tests run successfully.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@goncalo-frade-iohk goncalo-frade-iohk requested a review from a team as a code owner September 14, 2024 19:27
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/update-jose-swift-library branch 2 times, most recently from 514f960 to 79d1511 Compare September 16, 2024 14:04
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/update-jose-swift-library branch from 79d1511 to ca47ffa Compare September 17, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant