Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC fallback update #97

Merged
merged 1 commit into from
Nov 11, 2024
Merged

OIDC fallback update #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Sources/Main/Resolvers/CredentialOffer/AuthorizationServerMetadataResolver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,15 @@ public actor AuthorizationServerMetadataResolver: AuthorizationServerMetadataRes
url: URL
) async -> OIDCProviderMetadata? {

//According to the spec https://www.rfc-editor.org/rfc/rfc8414.html#section-3
// According to the spec https://www.rfc-editor.org/rfc/rfc8414.html#section-3
//“.well-known/oauth-authorization-server” need to be inserted after removing the path components first. e.g :
// https://example.com/.well-known/oauth-authorization-server/path1/path2
// We provide a fallback that simply appends the components
// Note: this fallback mechanism will be removed at a future date
do {
guard let insertedUrl = modifyURL(
url: url,
modificationType: .appendPathComponents(".well-known", "openid-configuration")
modificationType: .insertPathComponents(".well-known", "openid-configuration")
) else {
return nil
}
Expand All @@ -96,7 +97,7 @@ public actor AuthorizationServerMetadataResolver: AuthorizationServerMetadataRes

guard let appendedUrl = modifyURL(
url: url,
modificationType: .insertPathComponents(".well-known", "openid-configuration")
modificationType: .appendPathComponents(".well-known", "openid-configuration")
) else {
return nil
}
Expand Down