Enable res.render() callback argument #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
response.render()
method allows a callback to be provided as the second or third argument. Currently if this argument is used this library will not store the render data so assertions cannot be made on it.This PR refactors the mock
render()
method to allow a callback to be provided as the second or third argument and if present will call it rather than ending the response. It is intended to closely follow the logic implemented by Express.