Command not found on run

[tomkys144]

Hi,
when running pre-commit hook (either by git commit or by lefthook run) I get "command not found" error although in command line and in shell scripts everything works just fine...

config:

pre-commit:
  piped: true
  commands:
    1_lint_code:
      glob: '*.dart'
      run: dart fix --apply lib && git add .
    2_format_code:
      glob: '*.dart'
      run: flutter format {staged_files} && git add {staged_files}

Shell output:

Lefthook v0.7.7
RUNNING HOOKS GROUP: pre-commit

  EXECUTE > 1_lint_code
 sh: line 1: dart: command not found


 2_format_code (SKIP BY BROKEN PIPE)

SUMMARY: (done in 0.01 seconds)
🥊  1_lint_code

And in none-pipe mode:

Lefthook v0.7.7
RUNNING HOOKS GROUP: pre-commit

  EXECUTE > 1_lint_code
 sh: line 1: dart: command not found


  EXECUTE > 2_format_code
 sh: line 1: flutter: command not found


SUMMARY: (done in 0.02 seconds)
🥊  1_lint_code
🥊  2_format_code

[mrexox]

Hey! Do you edit your PATH env in .bashrc or something? Or maybe you have an alias? How are dart and flutter installed on your system?

[art-solopov]

I'm having a similar problem. I've aliased docker-compose to docker compose but it still doesn't work. Does lefthook not respect aliases?

[mrexox]

@art-solopov, did you write an alias in .bashrc or .zshrc? Lefthook uses sh as a shell, this might be a reason.

[qasim90]

@mrexox I can print PATH contents from sh with echo $PATH and it outputs all paths correctly but still Lefthook gives this error sh: flutter command not found when trying to commit. What is the solution?

[mrexox]

@qasim90 , could you provide more context?

• Where does flutter locate?
• What is your lefthook.yml?
• What is your lefthook version?

Maybe you have a public project, so I could reproduce the issue?

[mrexox]

I guess that the issue is related to some $PATH env var tweaks. Try setting rc for newest version of lefthook and feel free to open a new issue/discussion if it doesn't help. I am closing this issue.

[nerder]

The problem with this is that probably most people define their .lefthookrc they do something like that.

PATH="$PATH:$USER/flutter/bin"

this will not work with the " in the RC files, without the double quotes instead it will work. This is probably an issue with lefthook and how is running commands in a sub-shell.

cc @mrexox

[mrexox]

@nerder , can you please provide your lefthook.yml and .lefthookrc file? It will help me better understand the issue.

[nerder]

lefthook.yml

rc: ~/.lefthookrc

pre-push:
  parallel: true
  commands:
    linter:
      run: flutter analyze
    tests:
      interactive: true
      run: flutter test --coverage

pre-commit:
  parallel: true
  commands:
    check-secrets:
      interactive: true
      run: bash -c '${TALISMAN_HOME}/talisman_hook_script pre-commit'
    pretty:
      glob: '*.dart'
      exclude: '.*freezed\.dart|.*g\.dart|.*mocks\.dart'
      run: dart format -l 100 {staged_files} && git add {staged_files}

.lefthook.rc

PATH="$PATH:$USER/flutter/bin"

This wasn't working while running on the latest Ubuntu and latest version of lefthook, removing double-quotes fixes it

[mrexox]

@nerder, thank you for the example. Have your tried doing something like echo $PATH in one of the run options? How does the result change with double quotes and without them?

# lefthook.yml
...
pre-commit:
  parallel: true
  commands:
    pretty:
      glob: '*.dart'
      exclude: '.*freezed\.dart|.*g\.dart|.*mocks\.dart'
      # print $PATH -- how does this differ with and without quotes?
      run: |
        echo $PATH 
        dart format -l 100 {staged_files} && git add {staged_files}

Also, do you have paths like $USER/flutter/bin? Shouldn't it be $HOME/flutter/bin?