Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lefhook config in dependencies #30

Closed
marapper opened this issue Jul 25, 2019 · 3 comments
Closed

Lefhook config in dependencies #30

marapper opened this issue Jul 25, 2019 · 3 comments
Assignees
@Arkweid
Labels
enhancement New feature or request

Comments

@marapper
Copy link

We want to have lefthook in some library and use node_modules/@some/package/.lefthook.yml as a base config.

It would be great if we could add some parameters in package.json

or use something like inheritance in yaml like

# lefthook.yml
extends: @some/package/.lefthook.yml
@Arkweid Arkweid added the enhancement New feature or request label Jul 25, 2019
@Arkweid Arkweid self-assigned this Jul 25, 2019
@Arkweid
Copy link
Collaborator

Arkweid commented Jul 25, 2019

Make sense. I will add in the next version.

@Arkweid Arkweid mentioned this issue Sep 18, 2019
Closed
@Arkweid Arkweid mentioned this issue Oct 1, 2019
Merged
@Arkweid
Copy link
Collaborator

Arkweid commented Oct 1, 2019

Done: https://github.com/Arkweid/lefthook/blob/master/docs/full_guide.md#extends-option

@Arkweid Arkweid closed this as completed Oct 1, 2019
@marapper
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arkweid Arkweid

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marapper @Arkweid