Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-push hook fails in v1.5.5 but works in v1.5.4 for some cases #600

Closed
hustcer opened this issue Dec 25, 2023 · 2 comments
Closed

pre-push hook fails in v1.5.5 but works in v1.5.4 for some cases #600

hustcer opened this issue Dec 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@hustcer
Copy link

hustcer commented Dec 25, 2023

🔧 Summary

pre-push hook fails in v1.5.5 but works in v1.5.4 for some cases

Lefthook version

1.5.5 9b072e6

Steps to reproduce

I have tried the latest version of lefthook in https://github.com/hustcer/setup-nu repo:

lefthook-issue

The output of 1.5.5 does't look like 1.5.4, notice that this part is missing:

refs/heads/main e7fd469233d16703a7060d7b14feae806720659b refs/heads/main 26a18e5e4802a087f12cfcd83b832db8c2b1d07a
Pushing to remote...
----------------------------------

Expected results

1.5.5 should work the same as 1.5.4

Actual results

Possible Solution

Logs / Screenshots

LEFTHOOK_VERBOSE=true git ...
@hustcer hustcer added the bug Something isn't working label Dec 25, 2023
@mrexox
Copy link
Member

mrexox commented Jan 9, 2024

You are right. There was a change introduced in 1.5.5 - #590. Lefthook doesn't implicitly pass STDIN to subcommands/scripts. To fix this please use use_stdin: true option explicitly.

I forgot that this might be a breaking change. Do you have problems after this change?

@hustcer
Copy link
Author

hustcer commented Jan 9, 2024

That works for me, thanks.

@hustcer hustcer closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants