Fix lefthook capturing stdin from terminal even if when non-interactive and not using stdin #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve and not using stdin If I'm reading the code, this `args.in` should be a nullReader when non-interactive and not using stdin. For some reason though, it ends up capturing stdin. That is, any typing you do while lefthook is running goes to lefthook, instead of the shell invoking it. Fixes evilmartians#588
Would love to have tests for this, but I honestly have no idea about how to do it 😬 specifically because I have yet to reproduce #588 in an automated way |
|
I'm not sure why coveralls would fail 🤔 if anything, there's one less line to cover right?
|
|
That's OK. I think there are no tests that can cover this. Actually this part is legacy since it was here before the I will have this PR tested locally and then will come back with the resolution. Thank you for this finding! |
mrexox
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #588
⚡ Summary
If I'm reading the code, this
args.inshould be a nullReader when non-interactive and not using stdin. For some reason though, it ends up capturing stdin. That is, any typing you do while lefthook is running goes to lefthook, instead of the shell invoking it.☑️ Checklist