Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec.podTemplateSpec.metadata is not persisted #204

Closed
ekarlso opened this issue Feb 22, 2021 · 2 comments · Fixed by #221 or #260
Closed

spec.podTemplateSpec.metadata is not persisted #204

ekarlso opened this issue Feb 22, 2021 · 2 comments · Fixed by #221 or #260
Labels
bug Something isn't working

Comments

@ekarlso
Copy link
Contributor

ekarlso commented Feb 22, 2021

When you create a GAR instance the podTemplateSpec.metadata is {}, it seems there's some controller code / CRD code that is not working properly.

kubernetes-sigs/controller-tools#448
https://github.com/minio/operator/pull/423/files
kubernetes-sigs/controller-tools#539
@davidkarlsen davidkarlsen changed the title podTemplateSpec.metadata is never passed down onto pod's podTemplateSpec.metadata is not persisted Feb 22, 2021
@davidkarlsen davidkarlsen changed the title podTemplateSpec.metadata is not persisted spec.podTemplateSpec.metadata is not persisted Feb 22, 2021
@davidkarlsen davidkarlsen added the bug Something isn't working label Feb 22, 2021
@davidkarlsen davidkarlsen linked a pull request Feb 22, 2021 that will close this issue
Propagate metadata labels & annotations from podTemplateSpec #203
Merged
@davidkarlsen davidkarlsen removed a link to a pull request Feb 22, 2021
Propagate metadata labels & annotations from podTemplateSpec #203
Merged
@davidkarlsen
Copy link
Collaborator

Related #203

@ekarlso ekarlso mentioned this issue Feb 22, 2021
Closed
@davidkarlsen davidkarlsen mentioned this issue Mar 23, 2021
Merged
@davidkarlsen davidkarlsen reopened this Apr 20, 2021
@davidkarlsen davidkarlsen mentioned this issue Apr 20, 2021
Closed
@AmitBenAmi
Copy link

I saw that the tests should cover the error, but it still happens on my environment using the latest version (as stated in #233), with PR #221
Is it something caused by kubebuilder, or is it something specific in the controller of this operator?

@davidkarlsen davidkarlsen mentioned this issue Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@davidkarlsen @ekarlso @AmitBenAmi