Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official support for the latest version of k8s #578

Closed
kamil-branch opened this issue Aug 28, 2023 · 7 comments
Closed

Official support for the latest version of k8s #578

kamil-branch opened this issue Aug 28, 2023 · 7 comments
Assignees

Comments

@kamil-branch
Copy link

kamil-branch commented Aug 28, 2023

@davidkarlsen github-actions-runner-operator is widely used by many end users. The latest release of github-actions-runner-operator was made in November 2022. In the release notes we can see that it supports officially k8s 1.24 -> https://github.com/evryfs/github-actions-runner-operator/blob/v0.11.0/.github/workflows/build.yaml#L47
On the master branch there is a support for 1.26 but changes are not released -> https://github.com/evryfs/github-actions-runner-operator/blob/master/.github/workflows/build.yaml#L47
Latest k8s release is 1.28 and most of the cloud providers like AWS, Google etc provides support for k8s 1.27+. Additionally cloud providers require regular cluster upgrades. Could you release the new version of github-actions-runner-operator which officially supports k8s 1.27+?
Updating matrix compatibility of github-actions-runner-operator will help a lot all of the users with regular k8s upgrades.

@davidkarlsen
Copy link
Collaborator

@kamil-branch Unfortunately I no longer have commit-rights to the repo as I've switched jobs.
Maybe @Otterian can make me a contributor? That said the operator should work just fine on newer k8s versions too as it uses the stable versions - nevertheless it would be good to update the libraries in use and verify on newer k8s versions.
Keep in mind though that I don't have access to a k8s cluster connected to a gh-org for testing.

@kriberg
Copy link

kriberg commented Sep 1, 2023

@davidkarlsen: should've been sorted now.

@davidkarlsen davidkarlsen self-assigned this Sep 1, 2023
@davidkarlsen
Copy link
Collaborator

davidkarlsen commented Sep 1, 2023

@kamil-branch @Otterian @kriberg
Can you try quay.io/evryfs/github-actions-runner-operator:v0.11.0-29-gbb4b3c3 and also let me know the k8s version you tested on? As it passes in CI which tests on v1.26.6 and v1.28.0 and passes I expect it to be smooth sailing.

If so I can create a release.

@davidkarlsen
Copy link
Collaborator

@kamil-branch ? @Otterian?

@kamil-branch
Copy link
Author

Thanks for these changes David! Will make some tests tomorrow

@kamil-branch
Copy link
Author

@davidkarlsen so far I fully tested quay.io/evryfs/github-actions-runner-operator:v0.11.0-29-gbb4b3c3 on k8s 1.24.16 (same version where I've tested previous release quay.io/evryfs/github-actions-runner-operator:v0.11.0). I haven't noticed any issues - it works fine.

@davidkarlsen
Copy link
Collaborator

davidkarlsen commented Sep 10, 2023

Thanks. Released as v0.11.1: https://github.com/evryfs/github-actions-runner-operator/releases/tag/v0.11.1 - Chart in https://github.com/evryfs/helm-charts baking now.

GitHub
Changes

Bump actions/checkout from 3 to 4 @dependabot (#590)
Upgrade controller-runtime @davidkarlsen (#589)
Upgrade operator utils @davidkarlsen (#587)
Upgrade gomega @davidkarlsen (#588)
Upgrade...

GitHub
OpenSourced Helm charts. Contribute to evryfs/helm-charts development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants