Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Counts/Percentage selector for fgbio GroupReadsByUmi plot #1147

Merged
merged 4 commits into from
Apr 30, 2020

Conversation

nkrumm
Copy link
Contributor

@nkrumm nkrumm commented Apr 1, 2020

This PR adds a toggle for the GroupReadsByUmi plot in the fgbio module. Selecting between the absolute count and relative frequency is helpful when samples differ in total # of UMIs.

this PR is not a new module:

image

nkrumm and others added 4 commits April 1, 2020 00:52
@ewels
Copy link
Member

ewels commented Apr 30, 2020

This looks fab - thanks @nkrumm! I made one small tweak, multiplying the parsed fractions by 100. This is because the button said Percentages, but then the axis showed a fraction. For consistency I usually try to stick to percentages.

Let me know if you spot anything wrong with this,

Phil

@ewels ewels merged commit bb4ebc2 into MultiQC:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants