Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHIP value detection #1316

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

sstadick
Copy link
Contributor

@sstadick sstadick commented Oct 8, 2020

Previously the verifyBamID module was checking for an exact match of the string "CHIP" in a list [headers[i]], which would always be false. I've updated it to what I believe was the original intent, checking if the substring "CHIP" starts the header in question.

This will now allow for CHIP values to show up in the tables.

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@ewels ewels merged commit 21c609a into MultiQC:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants