Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Trigger for Starting AWS CodeBuild or notebook tests to GH environment #283

Open
ckunki opened this issue Jun 13, 2024 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Jun 13, 2024

Situation

In order to run specific tests, the developers currently need to push a (potentially empty) git commit with its message containing a specific string: [CodeBuild] for AWS CodeBuild tests and [run-notebook-tests] for note notebook tests.

Various other repositories are using a different mechanism based on GitHub environments to separate different phases of testing or deployments.

In the context of issue #295 this new mechanism has already been applied for executing the notebook-tests.

The current ticket requests to switch to using this new mechanism for executing the AWS CodeBuild, too.

For that, the filter in the AWS webhook (currently COMMIT_MESSAGE) probably needs to be changed to WORKFLOW_NAME.

References and details

AWS documentation.

Codebuild buildspec.yml should print branch and commit ID initially to enable debugging.
See SLC release for an example.

See repos

@ckunki ckunki added the refactoring Code improvement without behavior change label Jun 13, 2024
@ckunki ckunki changed the title Change Trigger for starting AWS CodeBuild to GH environment Change Trigger for starting AWS CodeBuild or notebook tests to GH environment Jun 13, 2024
@ckunki ckunki changed the title Change Trigger for starting AWS CodeBuild or notebook tests to GH environment Change Trigger for Starting AWS CodeBuild or notebook tests to GH environment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant