Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIBuild logs to debug while running build_test_container #46

Closed
tkilias opened this issue Jul 7, 2023 · 0 comments · Fixed by #49
Closed

CIBuild logs to debug while running build_test_container #46

tkilias opened this issue Jul 7, 2023 · 0 comments · Fixed by #49
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@tkilias
Copy link
Collaborator

tkilias commented Jul 7, 2023

Background

  • We are calling build_test_container from the ITDE which isn't a @clifunction as this, its parameter use_job_specific_log_file is false instead of true, for all the @clifunction, because they need the same defaults as the CLI.
  • Besides that, there is also build_test_container in SLCT, which is not used. One reason for this is, for testing we want to be able to use a different test_container
  • the likely correct way to resolve this issue, to explicitly set the logging options in at the call
  • Furthermore, we shouldn't trust the default of the api function we call, we should explicitly define what logging options we want in the CI

Acceptance Criteria

  • Set logging options in all SLCT api calls to
    • log_level = "INFO", use_job_specific_log_file = True
@tkilias tkilias added the bug Unwanted / harmful behavior label Jul 7, 2023
@MarleneKress79789 MarleneKress79789 self-assigned this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants