Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Page Freezes upon returning #17

Closed
ArmoredVortex opened this issue Mar 29, 2023 · 4 comments · Fixed by #20
Closed

[BUG] Page Freezes upon returning #17

ArmoredVortex opened this issue Mar 29, 2023 · 4 comments · Fixed by #20
Assignees

Comments

@ArmoredVortex
Copy link

ArmoredVortex commented Mar 29, 2023

Describe the bug

The startpage freezes when returning back using the "Go Back" button in the browser or Alt+Left shortcut.
Search commands and shortcuts still work, but "help", "fetch" etc don't.
Refreshing the page makes it work again. Console reports no error

To Reproduce

Steps to reproduce the behavior:

  1. Open startpage
  2. Search for something
  3. Return back using the "Go Back" button in browser
  4. Page freezes, no commands work

Expected behavior
Not freeze upon returning

Screenshots

2023-03-29.12-22-54.mp4

Specs:

  • OS: 6.2.8-arch1-1
  • Browser: Mozilla Firefox for Arch Linux 111.0.1 (64-bit)

Additional context
I encountered similar behavior on another startpage, issue is linked below
kholmogorov27/chevron#1

@excalith
Copy link
Owner

Hey @ArmoredVortex thank you so much for reporting this in a beautiful way! I will get working on it as soon as possible. Cheers!

@excalith excalith changed the title Page Freezes upon returning [BUG] [BUG] Page Freezes upon returning Mar 29, 2023
@excalith
Copy link
Owner

Hello @ArmoredVortex, I have a temporary fix for this. It will require more finesse and will fix this properly with the upcoming features since they will requre better state handling. You can preview the branch from this link: http://start-page-git-fix-page-freeze-excalith.vercel.app?_vercel_share=m2KiPmAzAgV6S7BcIyUA2Sgx3zY85Jcv

Would love to hear the status on your end. I will also try it on arch soon.

@ArmoredVortex
Copy link
Author

Oh wow, It works! No issues so far.
I can finally get to daily driving the startpage now.
Awesome startpage, Thanks! ❤️

@excalith
Copy link
Owner

I just tested on

  • Arch 6.1.7-arch1-1
  • Firefox 111.0.1 (64bit)

and also works on my machine 😄

Thanks again for the heads up, sending a PR and releasing v2.1.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants