Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a new release #710

Closed
barrelful opened this issue Feb 20, 2023 · 12 comments
Closed

Please create a new release #710

barrelful opened this issue Feb 20, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@barrelful
Copy link

Context

I see many improvements were made in the library and also support for newer Sphinx.

Proposal

Would be excellent if you can release a new version.

Tasks and updates

No response

@barrelful barrelful added the enhancement New feature or request label Feb 20, 2023
@welcome
Copy link

welcome bot commented Feb 20, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

chrisjsewell commented Feb 20, 2023

Just keeping people waiting so they appreciate it more 😅

But no it will be soon, with lots of improvements

@pablo-de-andres
Copy link

I was currently updating dependencies in my docs, and got a conflict because myst-parser 0.18.1 depends on sphinx<6 and >=4.
Sphinx 6.1.3 is out, and I see the main branch would support it. So +1 :)

@staticdev
Copy link

@chrisjsewell just to avoid headaches and new issues, I always avoid capping max versions of dependencies unless I am very sure it will not work. This also minimizes overhead communication of each new version launched. In your case I would just change:

https://github.com/executablebooks/MyST-Parser/blob/master/pyproject.toml#L42

to "sphinx>=5"

There is an extensive article with ideas related to that just in case: https://iscinumpy.dev/post/bound-version-constraints/

@chrisjsewell
Copy link
Member

I always avoid capping max versions of dependencies unless I am very sure it will not work.

I am very sure it will not work

@chrisjsewell
Copy link
Member

There is an extensive article with ideas related to that just in case: iscinumpy.dev/post/bound-version-constraints

image

@staticdev
Copy link

staticdev commented Feb 21, 2023

@chrisjsewell you have a good point but unfortunately/fortunately almost everyone is using poetry nowadays, and poetry does not ignore that. And by very sure I would say, there is an available release of sphinx 7 (which wasn't in last 5 min) and you tested against latest code and does not work. But this is just a suggestion of course, you know your project better than me for sure and you read it then =)

@barrelful
Copy link
Author

Just keeping people waiting so they appreciate it more sweat_smile

But no it will be soon, with lots of improvements

Hunger is the best spice.

@chrisjsewell
Copy link
Member

FYI, this is basically where I wanted to get to 😅 https://myst-parser--717.org.readthedocs.build/en/717/
If you look through the authoring sections, lots of nice improvements 👌

@staticdev
Copy link

It looks excellent, great job!

@mgielda
Copy link

mgielda commented Feb 26, 2023

I can only +1 here :) we are adopting many of the new syntactic solutions, and the myst-example directive is super nice for showing off cool MyST tricks!

@chrisjsewell
Copy link
Member

Its here boys and girls 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants